This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Add MultiValueArithmeticDriver<T> Component #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the check is failing :/ |
|
OH yeah the github action script has been broken for a long time |
|
has this been fully tested in a multi user enviroment |
No not yet. |
|
when do you want to test ? |
|
sorry I have been busy with stuff so haven't been able to test, but hopefully soon |
Frozenreflex
suggested changes
Aug 8, 2023
| using System.Linq; | ||
| using BaseX; | ||
| using FrooxEngine; | ||
|
|
There was a problem hiding this comment.
There needs to be a namespace defined here,
namespace FrooxEngine;should do.
(Linka please fix the namespaces in your code it's missing in a couple of places and dropping stuff to the global namespace is bad)
|
|
||
| protected override void OnChanges() | ||
| { | ||
| if (!Target.IsLinkValid) |
There was a problem hiding this comment.
This could probably be reformatted to something like this
if (!Target.IsLinkValid || Values.Count == 0) return;
Frozenreflex
reviewed
Aug 8, 2023
| } | ||
| if (Values.Contains(Target.Target)) | ||
| { | ||
| // don't let the component drive itself, don't want a feedback loop |
Frozenreflex
approved these changes
Aug 9, 2023
|
approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's basically a small calculator in components. You can add, subtract, multiply or divide with it. You can also type values straight into the component or drive them from elsewhere.