Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Add more nodes that return slot collections (and add my Neos path to csproj) #150

Merged
merged 12 commits into from
Sep 15, 2023

Conversation

Nytra
Copy link
Contributor

@Nytra Nytra commented Jul 27, 2023

Add GetAllParents and GetAllChildren nodes, GetChildrenWithName/Tag and GetParentsWithName/Tag. Also adds my Neos path to the .csproj.

@Xlinka
Copy link
Owner

Xlinka commented Jul 30, 2023

has this been tested ?

@Nytra
Copy link
Contributor Author

Nytra commented Jul 30, 2023

has this been tested ?

I tested them myself briefly and they all seemed to work.

@Xlinka
Copy link
Owner

Xlinka commented Sep 5, 2023

hello nytra just coming back round to all this are you available sometime to show me these.

@Xlinka
Copy link
Owner

Xlinka commented Sep 5, 2023

@Frozenreflex want to review this since the collection stuff is your brain child

@Xlinka
Copy link
Owner

Xlinka commented Sep 13, 2023

just went through and tested them these seem to work on my system

@Nytra
Copy link
Contributor Author

Nytra commented Sep 14, 2023

Linka said the nodes here should be outputting ReadOnlyCollections instead of Lists. If this is the case then probably the existing GetChildrenWithTag LogiX node (which was previously merged) should be updated as well.

@Xlinka
Copy link
Owner

Xlinka commented Sep 14, 2023

It's something @Frozenreflex said and I'm just wondering if I misinterpreted what they said or if we must do this wait till they reply

@Xlinka
Copy link
Owner

Xlinka commented Sep 15, 2023

oof conflict tag @Nytra soryyy

@Nytra
Copy link
Contributor Author

Nytra commented Sep 15, 2023

Fixed conflict, also fixed category strings and a couple of bugs

@Xlinka Xlinka merged commit 7ff74f1 into Xlinka:main Sep 15, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants