Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small fixes: Call base.OnAttach in OnAttach, use full typename in logs instead of hashcode #37

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Some small fixes: Call base.OnAttach in OnAttach, use full typename in logs instead of hashcode #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ProjectObsidian/Components/Common UI/Button Interactions/ButtonAttachComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class ButtonAttachComponent : Component, IButtonPressReceiver, IComponent

protected override void OnAttach()
{
base.OnAwake();
base.OnAttach();
Undoable.Value = true;
}

Expand Down
2 changes: 1 addition & 1 deletion ProjectObsidian/Components/Radiant UI/Data Feeds/Feeds/ComponentsDataFeedData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ private ComponentData RegisterComponentType(Type type, out bool createdEntry)

if (!createdEntry)
{
throw new InvalidOperationException("Component with this Type has already been added! Type: " + GetUniqueId(type));
throw new InvalidOperationException("Component with this Type has already been added! Type: " + type.FullName);
}

return componentData;
Expand Down