Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON nodes, improve binding generator, add external types to AssemblyInfo.cs and mark enums as data model types #44

Closed
wants to merge 7 commits into from

Conversation

Nytra
Copy link
Contributor

@Nytra Nytra commented Jul 14, 2024

Marks necessary types as data model types

Improves binding generator to use constraint clauses and generic types attribute

Fixes JSON nodes, create value and object variants of the nodes

Closes #42

@Nytra Nytra changed the title Add external types to AssemblyInfo.cs Add external types to AssemblyInfo.cs and mark some enums as data model types Jul 14, 2024
@Nytra Nytra changed the title Add external types to AssemblyInfo.cs and mark some enums as data model types Fix JSON nodes, improve binding generator, Add external types to AssemblyInfo.cs and mark some enums as data model types Jul 14, 2024
@Nytra Nytra changed the title Fix JSON nodes, improve binding generator, Add external types to AssemblyInfo.cs and mark some enums as data model types Fix JSON nodes, improve binding generator, add external types to AssemblyInfo.cs and mark enums as data model types Jul 14, 2024
@Frozenreflex
Copy link
Collaborator

I'm already redoing the Json nodes

@Nytra
Copy link
Contributor Author

Nytra commented Jul 14, 2024

@Frozenreflex How are you redoing them?

@Frozenreflex
Copy link
Collaborator

@Nytra Check my branch

@Nytra
Copy link
Contributor Author

Nytra commented Jul 14, 2024

@Frozenreflex I think adding the generic types attribute to the binding generator would be a good idea because then you can populate the common generic types list in the UI

@Nytra
Copy link
Contributor Author

Nytra commented Jul 14, 2024

@Frozenreflex Also, you can't connect ProtoFlux value inputs to ObjectInput<T> it needs to be a ValueInput<T> that's why in my PR I split the nodes into Object and Value variants.

@Frozenreflex
Copy link
Collaborator

why do i put up with this game's bad design choices

i'd already encountered that for the outputs, but i guess i didn't test the inputs, gonna do that in a sec

@Frozenreflex
Copy link
Collaborator

public struct ObjectInput<T> : IObjectInput<T>, IInput<T>, IInput
public class ObjectOutput<T> : Output<T>, IObjectOutput<T>, IOutput<T>, IOutput
public struct ValueInput<T> : IValueInput<T>, IInput<T>, IInput where T : unmanaged
public class ValueOutput<T> : Output<T>, IValueOutput<T>, IOutput<T>, IOutput where T : unmanaged

why

also i fixed it if you want to look at it

@Nytra
Copy link
Contributor Author

Nytra commented Jul 14, 2024

@Frozenreflex

Should be ValueInput<T>

@Nytra
Copy link
Contributor Author

Nytra commented Jul 14, 2024

@Xlinka I think Frozen's branch should be merged then I will make additional PRs later

@Nytra Nytra closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Nodes all seem to be broken
2 participants