Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: Improving Developer Onboarding #XON-Hackathon-2024 #10

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

jbhv12
Copy link
Contributor

@jbhv12 jbhv12 commented Jan 25, 2024

This pull request is focused on enhancing the developer experience, particularly for new contributors. The key improvements include:

  • Upgraded Python version to 3.12

  • Created Docker Compose file

  • Updated README file

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Welcome to our project! Your first pull request marks an exciting moment for us. We're eager to review your contribution and collaborate to merge it into our codebase. Thanks for investing your time in improving our project. If you have any questions or need help, don't hesitate to

@@ -1,8 +1,7 @@

# Use the official lightweight Python image.
# https://hub.docker.com/_/python
#FROM python:3.10-slim
FROM python:3.8-slim
FROM python:3.12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not using slim version, since some of the dependencies need to be compiled with gcc, which is not included in slim.

@jbhv12 jbhv12 changed the title 🧹 chore: Improving Developer Onboarding 🧹 chore: Improving Developer Onboarding #XON-Hackathon-2024 Jan 25, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DevaOnBreaches DevaOnBreaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Much appreciated for bringing in an easy on-boarding experience for developers.

This looks good to me and you may revise those two comments highlighted and submit for acceptance.

@DevaOnBreaches DevaOnBreaches merged commit b1f4aef into XposedOrNot:master Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants