-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 chore: Improving Developer Onboarding #XON-Hackathon-2024 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Welcome to our project! Your first pull request marks an exciting moment for us. We're eager to review your contribution and collaborate to merge it into our codebase. Thanks for investing your time in improving our project. If you have any questions or need help, don't hesitate to
@@ -1,8 +1,7 @@ | |||
|
|||
# Use the official lightweight Python image. | |||
# https://hub.docker.com/_/python | |||
#FROM python:3.10-slim | |||
FROM python:3.8-slim | |||
FROM python:3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not using slim version, since some of the dependencies need to be compiled with gcc, which is not included in slim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Much appreciated for bringing in an easy on-boarding experience for developers.
This looks good to me and you may revise those two comments highlighted and submit for acceptance.
This pull request is focused on enhancing the developer experience, particularly for new contributors. The key improvements include:
Upgraded Python version to 3.12
Created Docker Compose file
Updated README file