Skip to content

[codex] Add screenplay draft governance and format checks#8

Merged
XucroYuri merged 2 commits intomainfrom
codex/core-chain-script-governance
Apr 2, 2026
Merged

[codex] Add screenplay draft governance and format checks#8
XucroYuri merged 2 commits intomainfrom
codex/core-chain-script-governance

Conversation

@XucroYuri
Copy link
Copy Markdown
Owner

Summary

  • add machine-checked golden artifact format contracts, including screenplay block validation for scene_draft and the new screenplay_draft
  • wire screenplay_draft through routing, scene-writing protocols, rubrics, fixtures, and runtime expression-lens metadata
  • add failure archive cases for missing performance carriers, AV cue omission, and cross-artifact naturalness drift

Validation

  • python3 -m unittest discover -s tests -v

@XucroYuri XucroYuri marked this pull request as ready for review April 2, 2026 08:57
@XucroYuri XucroYuri merged commit 41d2218 into main Apr 2, 2026
2 checks passed
@XucroYuri XucroYuri deleted the codex/core-chain-script-governance branch April 2, 2026 08:57
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a58495dec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +191 to +193
contract_by_output = {
contract["output"]: contract
for contract in contracts.get("contracts", [])
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Skip contract indexing when schema validation fails

If references/output-format-contracts.json is malformed (for example, a contract entry is missing output), this function already records schema errors but then immediately builds contract_by_output with contract["output"], which raises KeyError and aborts the check. In that scenario the script crashes instead of returning the collected validation report, so CI/users lose actionable diagnostics on the actual schema violation.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant