chore: Update CI workflow to remove linting step

XueDAOTW · Jun 16, 2024 · c2c57be · c2c57be
1 parent e320ea7
commit c2c57be
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 37 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,39 +12,6 @@ on:
       - "main"
 
 jobs:
-  lint:
-    runs-on: "ubuntu-latest"
-    steps:
-      - name: "Check out the repo"
-        uses: "actions/checkout@v3"
-        with:
-          submodules: "recursive"
-
-      - name: "Install Foundry"
-        uses: "foundry-rs/foundry-toolchain@v1"
-
-      - name: "Install Pnpm"
-        uses: "pnpm/action-setup@v2"
-        with:
-          version: "8"
-
-      - name: "Install Node.js"
-        uses: "actions/setup-node@v3"
-        with:
-          cache: "pnpm"
-          node-version: "lts/*"
-
-      - name: "Install the Node.js dependencies"
-        run: "pnpm install"
-
-      - name: "Lint the contracts"
-        run: "pnpm lint"
-
-      - name: "Add lint summary"
-        run: |
-          echo "## Lint result" >> $GITHUB_STEP_SUMMARY
-          echo "✅ Passed" >> $GITHUB_STEP_SUMMARY
-
   build:
     runs-on: "ubuntu-latest"
     steps:

diff --git a/README.md b/README.md
@@ -1,4 +1,3 @@
-
 # 24-frontend-workshop-contract-template
 
 This is a template for the 24 frontend workshop contract.
@@ -21,6 +20,7 @@ $ cd 24-frontend-workshop-contract-template
    ```
 
    Using `pnpm`:
+
    ```sh
    $ pnpm install
    ```
@@ -36,6 +36,7 @@ $ forge build
    If you did not set up a MNEMONIC environment variable, you can use the `--private-key` flag to deploy the contracts.
 
    For general deployment:
+
    ```sh
    forge script script/Deploy.s.sol \
        --rpc-url <RPC_URL> \
@@ -46,6 +47,7 @@ $ forge build
    ```
 
    Example using the Zircuit chain:
+
    ```sh
    forge script script/Deploy.s.sol \
        --rpc-url zircuit \
@@ -71,9 +73,18 @@ $ forge build
    ```sh
    forge verify-contract \
        --verifier-url https://explorer.zircuit.com/api/contractVerifyHardhat \
-       <deployed-contract-address> \
-       <source-file>:<contract-name> \
-       --etherscan-api-key <ZIRCUIT_API_KEY>
+       <deployed-mock-erc20-address> \
+       src/MockERC20.sol:MockERC20 \
+       --etherscan-api-key <ZIRCUIT-API-KEY>
+   ```
+
+   ```sh
+   forge verify-contract \
+       --verifier-url https://explorer.zircuit.com/api/contractVerifyHardhat \
+       <deployed-xue-membership-nft-address> \
+       src/XueMembershipNFT.sol:XueMembershipNFT \
+       --etherscan-api-key <ZIRCUIT-API-KEY> \
+       --constructor-args $(cast abi-encode "constructor(string)" "https://xuedaoisgood.com/")
    ```
 
 ## Common Usage