Fix : 어드민 멤버제거 기능에서 잘못 사용되는 UseCase 제거 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DeleteMember는 회원 스스로가 탈퇴할때를 가정한 UseCase로 Local의 Memeber Id를 함께 제거하는 로직이 있음 - DeleteMemeberUseCase를 사용하지 않고 MemberRepository의 deleteMember 메서드를 사용하여 DB에서만 제거
- 'Delete' 라는 명칭이 어드민 기능 구현시 혼동을 줄 수 있어, 회원탈퇴를 명확히 나타내는 이름으로 수정합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeleteMemberUseCase -> WithdrawMemberUseCase 로 명칭 변경
WithdrawMemberUseCase는 회원 스스로가 탈퇴할때를 가정한 UseCase로 Local의 Memeber Id를 함께 제거하는 로직이 있음
때문에 이를 사용하지 않고 MemberRepository의 deleteMember 메서드를 사용하여 DB에서만 제거
(어드민이 [카카오 로그인 API] 에서 탈퇴시키는것은 불가)
멤버 제거 성공 / 실패시 Toast를 사용하여 알림 추가
Screen Shots
Check List