로그인 & 디자인 시스템 일부 적용 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShapeKim98
approved these changes
Jan 8, 2025
| case border | ||
| } | ||
|
|
||
| public struct YPButtonStyle: ButtonStyle { |
There was a problem hiding this comment.
ButtonStyle, TextFieldStyle 보면서 그동안 디자인시스템 헛으로 만들었다는 것을 깨달았습니다... 많이 배우겠슴다,,,
| @@ -9,15 +9,20 @@ import SwiftUI | |||
|
|
|||
| // MARK: - Gray Scale | |||
| public extension Color { | |||
| static let gray22: Color = .init(uiColor: .init(hex: "#70737C")).opacity(0.22) | |||
| static let gray22: Color = .init(hex: "#70737C").opacity(0.22) | |||
There was a problem hiding this comment.
이거 그냥 헥스값으로 하신 이유가 있나여? 좀 힘들었을 것 같은데...
| .padding(.vertical, verticalPadding) | ||
| .foregroundStyle(foregroundColor) | ||
| .background(backgroundColor) | ||
| .if(colorStyle == .border) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
https://yappu-world.atlassian.net/browse/YPW-44
🌱 Key changes
https://www.notion.so/yapp-workspace/9b55d6aad49f4bcfafcea30cb6a65d17?pvs=4
(위 링크는 재사용 관련해서 제작해놓은 코드 간단하게 정리한 링크)
✅ To Reviewers
📸 스크린샷