Added setting to enable/disable the overstrum/overhit sound effect

Assets/Script/Gameplay/Player/DrumsPlayer.cs

@@ -78,7 +78,7 @@ protected override DrumsEngine CreateEngine()
 
             engine.OnNoteHit += OnNoteHit;
             engine.OnNoteMissed += OnNoteMissed;
-            engine.OnOverhit += OnOverstrum;
+            engine.OnOverhit += OnOverhit;
 
             engine.OnSoloStart += OnSoloStart;
             engine.OnSoloEnd += OnSoloEnd;

Assets/Script/Gameplay/Player/FiveFretPlayer.cs

@@ -10,6 +10,7 @@
 using YARG.Gameplay.HUD;
 using YARG.Gameplay.Visuals;
 using YARG.Player;
+using YARG.Settings;
 
 namespace YARG.Gameplay.Player
 {
@@ -88,7 +89,7 @@ protected override GuitarEngine CreateEngine()
 
             engine.OnNoteHit += OnNoteHit;
             engine.OnNoteMissed += OnNoteMissed;
-            engine.OnOverstrum += OnOverstrum;
+            engine.OnOverstrum += OnOverhit;
 
             engine.OnSustainStart += OnSustainStart;
             engine.OnSustainEnd += OnSustainEnd;
@@ -190,16 +191,18 @@ protected override void OnNoteMissed(int index, GuitarNote chordParent)
             }
         }
 
-        protected override void OnOverstrum()
+        protected override void OnOverhit()
         {
-            base.OnOverstrum();
+            base.OnOverhit();
 
-            const int min = (int) SfxSample.Overstrum1;
-            const int max = (int) SfxSample.Overstrum4;
-
-            var randomOverstrum = (SfxSample) Random.Range(min, max + 1);
+            if (SettingsManager.Settings.OverstrumAndOverhitSoundEffects.Value)
+            {
+                const int MIN = (int) SfxSample.Overstrum1;
+                const int MAX = (int) SfxSample.Overstrum4;
 
-            GlobalAudioHandler.PlaySoundEffect(randomOverstrum);
+                var randomOverstrum = (SfxSample) Random.Range(MIN, MAX + 1);
+                GlobalAudioHandler.PlaySoundEffect(randomOverstrum);
+            }
         }
 
         private void OnSustainStart(GuitarNote parent)

Assets/Script/Gameplay/Player/TrackPlayer.cs

@@ -443,7 +443,7 @@ protected virtual void OnNoteMissed(int index, TNote note)
             }
         }
 
-        protected virtual void OnOverstrum()
+        protected virtual void OnOverhit()
         {
             if (IsFc)
             {

Assets/Script/Settings/SettingsManager.Settings.cs

@@ -157,6 +157,8 @@ public void OpenVenueFolder()
 
             public ToggleSetting ClapsInStarpower { get; } = new(true);
 
+            public ToggleSetting OverstrumAndOverhitSoundEffects { get; } = new(true);
+
             // public ToggleSetting UseWhammyFx            { get; } = new(true, UseWhammyFxChange);
             // public SliderSetting WhammyPitchShiftAmount { get; } = new(1, 1, 12, WhammyPitchShiftAmountChange);
             // public IntSetting    WhammyOversampleFactor { get; } = new(8, 4, 32, WhammyOversampleFactorChange);

Assets/Script/Settings/SettingsManager.cs

@@ -87,6 +87,7 @@ public static partial class SettingsManager
                 // nameof(Settings.WhammyPitchShiftAmount),
                 // nameof(Settings.WhammyOversampleFactor),
                 nameof(Settings.ClapsInStarpower),
+                nameof(Settings.OverstrumAndOverhitSoundEffects),
                 // nameof(Settings.ReverbInStarpower),
                 nameof(Settings.UseChipmunkSpeed),
                 nameof(Settings.ApplyVolumesInMusicLibrary),

Assets/StreamingAssets/lang/en-US.json

@@ -439,6 +439,10 @@
                 "Name": "Star Power Claps",
                 "Description": "Enables claps to the beat while Star Power is active."
             },
+            "OverstrumAndOverhitSoundEffects": {
+                "Name": "Overstrum/Overhit Sound Effects",
+                "Description": "Enables the overstrum/overhit sound effect."
+            },
             "CrowdVolume": {
                 "Name": "Crowd Volume",
                 "Description": "Adjusts the song's crowd track volume. Only does something if the song is multi-track."