Try to prevent inputs from getting stuck active when a device disconn…

…ects
YARC-Official · Oct 17, 2024 · 90b14ed · 90b14ed
1 parent 7574bf7
commit 90b14ed
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/Assets/Script/Input/Bindings/AxisBinding.cs b/Assets/Script/Input/Bindings/AxisBinding.cs
@@ -164,6 +164,13 @@ public override void UpdateState(double time)
             InvokeStateChanged(State);
         }
 
+        public override void ResetState()
+        {
+            RawState = default;
+            State = default;
+            InvokeStateChanged(State);
+        }
+
         private float CalculateState(float rawValue)
         {
             float max;

diff --git a/Assets/Script/Input/Bindings/ButtonBinding.cs b/Assets/Script/Input/Bindings/ButtonBinding.cs
@@ -164,6 +164,14 @@ public override void UpdateState(double time)
             InvokeStateChanged(State);
         }
 
+        public override void ResetState()
+        {
+            PreviousState = default;
+            State = default;
+            _debounceTimer.Stop();
+            InvokeStateChanged(State);
+        }
+
         private float CalculateState(float rawValue)
         {
             return rawValue * _invertSign;

diff --git a/Assets/Script/Input/Bindings/ControlBinding.cs b/Assets/Script/Input/Bindings/ControlBinding.cs
@@ -193,6 +193,12 @@ public virtual void UpdateState(double time)
             InvokeStateChanged(State);
         }
 
+        public virtual void ResetState()
+        {
+            State = default;
+            InvokeStateChanged(State);
+        }
+
         protected void InvokeStateChanged(TState state)
         {
             StateChanged?.Invoke(state);
@@ -434,6 +440,12 @@ private bool RemoveBindings(Func<TBinding, bool> selector)
                 if (selector(binding))
                 {
                     removed = true;
+
+                    // Reset binding state to prevent phantom inputs
+                    binding.ResetState();
+                    OnStateChanged(binding, InputManager.CurrentInputTime);
+                    FireStateChanged();
+
                     _bindings.RemoveAt(i);
                     FireBindingRemoved(binding.Control);
                     i--;