add custom group_by for RESOURCE_NAME (#25)

* add custom group_by for RESOURCE_NAME
YaleSpinup · Jul 8, 2021 · e0ea54d · e0ea54d
1 parent 75c3512
commit e0ea54d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -134,7 +134,7 @@ GET /v1/cost/{account}/spaces/{spaceid}?start=2021-04-01&end=2021-05-31
 GET /v1/cost/{account}/spaces/{spaceid}?start=2021-04-01&end=2021-05-31&groupby=INSTANCE_TYPE_FAMILY
 ```
 
-Valid 'groupby' values are AZ, INSTANCE_TYPE, LINKED_ACCOUNT, OPERATION, PURCHASE_TYPE, SERVICE, USAGE_TYPE, PLATFORM, TENANCY, RECORD_TYPE, LEGAL_ENTITY_NAME, DEPLOYMENT_OPTION, DATABASE_ENGINE, CACHE_ENGINE, INSTANCE_TYPE_FAMILY, REGION, BILLING_ENTITY, RESERVATION_ID, SAVINGS_PLANS_TYPE, SAVINGS_PLAN_ARN, OPERATING_SYSTEM.
+Supported default 'groupby' values are AZ, INSTANCE_TYPE, LINKED_ACCOUNT, OPERATION, PURCHASE_TYPE, SERVICE, USAGE_TYPE, PLATFORM, TENANCY, RECORD_TYPE, LEGAL_ENTITY_NAME, DEPLOYMENT_OPTION, DATABASE_ENGINE, CACHE_ENGINE, INSTANCE_TYPE_FAMILY, REGION, BILLING_ENTITY, RESERVATION_ID, SAVINGS_PLANS_TYPE, SAVINGS_PLAN_ARN, OPERATING_SYSTEM. In addition, the custom RESOURCE_NAME 'groupby' is supported using the Name tag.
 
 #### Response
 

diff --git a/api/handlers_spaces.go b/api/handlers_spaces.go
@@ -82,7 +82,15 @@ func (s *server) SpaceGetHandler(w http.ResponseWriter, r *http.Request) {
 		},
 	}
 
-	if groupBy != "" {
+	switch {
+	case groupBy == "RESOURCE_NAME":
+		input.GroupBy = []*costexplorer.GroupDefinition{
+			{
+				Key:  aws.String("Name"),
+				Type: aws.String("TAG"),
+			},
+		}
+	case groupBy != "":
 		input.GroupBy = []*costexplorer.GroupDefinition{
 			{
 				Key:  aws.String(groupBy),