Added a module that tracks statistics and sends them to the server#1
Open
YazoonDinalt wants to merge 22 commits intomainfrom
Open
Added a module that tracks statistics and sends them to the server#1YazoonDinalt wants to merge 22 commits intomainfrom
YazoonDinalt wants to merge 22 commits intomainfrom
Conversation
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
S1eGa
suggested changes
Nov 13, 2024
S1eGa
left a comment
S1eGa
left a comment
There was a problem hiding this comment.
Despite an existing datarace looks good.
Please, apply clang-format as it is specified in one of the CI tasks in the .github directory.
| ObjectManager(); | ||
| ~ObjectManager(); | ||
|
|
||
| std::unordered_map<CallPathNode *, StatisticRecord *> StatisticMap; |
There was a problem hiding this comment.
Still do not agree with locating StatisticMap in the ObjectManager.
| << "KLEE: done: forks = " << forks << '\n' | ||
| << "KLEE: done: coverage = " | ||
| << (static_cast<double>(handler->getNumPathsCompleted()) / | ||
| static_cast<double>(handler->getNumTestCases())) * |
There was a problem hiding this comment.
Which coverage do you count in that way? =)
… invocation Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
S1eGa
reviewed
Nov 21, 2024
lib/Core/Executor.cpp
Outdated
| if (std::chrono::duration_cast<std::chrono::milliseconds>( | ||
| currentTime - lastExecutionTime) | ||
| .count() >= 100) { | ||
| auto localStatisticMap = objectManager->StatisticMap; |
There was a problem hiding this comment.
Data race: copied in producer, modified by the executor.
Signed-off-by: YazoonDinalt <kykyky228kykyk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module contains several new classes, namely serverConnection for working with the server, Delta for preparing statistics for sending to the server, StatisticQueue a queue with a mutex for secure work with data. Added two threads that work with data and send information to the server once at a certain time