Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN: grammar tweaks, clarity changes, dead link in README #590

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

AwesomeTornado
Copy link
Contributor

This pull request contains the following:

  • Minor grammar changes
  • Rewording of some confusing descriptions
  • New link for the README

Minor grammar changes

These changes are in the exact same style as my previous pull request, linked here, with the following description:

There were a few strings with confusing grammar consisting of a question being used as a statement.
I think it's called a subject-auxiliary verb inversion? I'm not a linguistics major though, so I'm not sure.
Example below:
Old version:
this controls what will [something] do
New version:
this controls what [something] will do

Rewording of some confusing descriptions

I have changed how the double click interval and the noise gate are explained. I believe that the updated descriptions do a better job of explaining what these settings actually do, however I would appreciate some confirmation here.

New link for the README

This is a fix for issue #332. Using the Internet Archive, I was able to determine which of the two links referenced in the issue was the intended link.
The Internet archive link I used can be found below.
http://web.archive.org/web/20201108210300/https://messageformat.github.io/messageformat/page-guide
Credit to @Banane9 for doing all of the work for this part, all I have really done is created the PR.

@Banane9
Copy link

Banane9 commented Dec 3, 2024

Glad someone picked up fixing that :D

@Frooxius Frooxius merged commit f588bd8 into Yellow-Dog-Man:main Dec 4, 2024
1 check passed
@Frooxius
Copy link
Member

Frooxius commented Dec 4, 2024

Thank you for the tweaks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants