Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for empty val. Merge json correctly #1024

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add check for empty val. Merge json correctly #1024

merged 1 commit into from
Jan 16, 2025

Conversation

KaspariK
Copy link
Member

@KaspariK KaspariK commented Jan 16, 2025 •
edited
Loading

We need to check for the existence of the pickle partition. We also need to be adding the JSON partitions together instead of reassigning!

@KaspariK KaspariK marked this pull request as ready for review January 16, 2025 16:38
@KaspariK KaspariK requested a review from a team as a code owner January 16, 2025 16:38
@KaspariK KaspariK merged commit 71235c6 into master Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemacysts nemacysts nemacysts approved these changes

@EmanElsaban EmanElsaban Awaiting requested review from EmanElsaban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaspariK @nemacysts