Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Tron to py3.8 + patching it with the fix #934

Merged
merged 19 commits into from
Jan 31, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix InvariantException back to Exception
  • Loading branch information
EmanElsaban committed Jan 29, 2024
commit a7b38d0a83facefa64386e9e981f113b89ac7099
3 changes: 1 addition & 2 deletions tron/core/actionrun.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@
from typing import Set
from typing import Union

from pyrsistent import InvariantException
from twisted.internet import reactor

from tron import command_context
@@ -1176,7 +1175,7 @@ def submit_command(self, attempt: ActionRunAttempt) -> Optional[KubernetesTask]:
service_account_name=attempt.command_config.service_account_name,
ports=attempt.command_config.ports,
)
except InvariantException:
except Exception:
log.exception(f"Unable to create task for ActionRun {self.id}")
self.fail(exitcode.EXIT_KUBERNETES_TASK_INVALID)
return None
Loading