Change jsonschema extra to format-nongpl #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtwang
changed the title
jtwang
changed the title
benbariteau
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonschema[format]is GPL, which is in conflict with our BSD license. Switching over to the conveniently availablejsonschema[format-nongpl]extra fixes this.Additionally, add rfc3339-validator to requirements-dev.txt to workaround a mystery issue where pip is not installing this dependency (defined in
jsonschema[format-nongpl) by default, causing the date time validator to pass all inputs, even invalid ones.And finally, ignore a bunch of lines for mypy type checks. These were already failing on master.