To add pass as keyword for detecting secrets under label pass#658
Open
justjais wants to merge 1 commit intoYelp:masterfrom
Open
To add pass as keyword for detecting secrets under label pass#658justjais wants to merge 1 commit intoYelp:masterfrom
justjais wants to merge 1 commit intoYelp:masterfrom
Conversation
Member
|
Hi. Please merge master to your branch to re-run CI. |
lorenzodb1
reviewed
Mar 31, 2023
Contributor
lorenzodb1
left a comment
lorenzodb1
left a comment
There was a problem hiding this comment.
What worries me about these changes is that it could potentially increase the number of false positives. @justjais is there a specific use case related to these changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the keyword list for detecting content under
passkeyword as secrets, along withpassword,passwdandpwd.Secret password under
passlabel is not getting detected as secretsWhat is the new behavior (if this is a feature change)?
Secret password under
passlabel will be detected as secrets with the PR changeDoes this PR introduce a breaking change?
No.