Support new python versions and upgrade pytest to 7.4.3 #717
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, I get a `TypeError: required field "lineno" missing from alias` error with Python 3.10. E.g.: ``` $ tox -e py310 .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True attrs==21.4.0 setuptools.build_meta __legacy__ .pkg: get_requires_for_build_sdist> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_wheel> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: prepare_metadata_for_build_wheel> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_sdist> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ py310: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/detect-secrets/.tox/.tmp/package/4/detect_secrets-1.4.0.tar.gz py310: commands[0]> coverage erase py310: commands[1]> coverage run -m pytest --strict tests ImportError while loading conftest '/Users/abramowi/Code/OpenSource/detect-secrets/tests/conftest.py'. TypeError: required field "lineno" missing from alias py310: exit 4 (0.16 seconds) /Users/abramowi/Code/OpenSource/detect-secrets> coverage run -m pytest --strict tests pid=74616 .pkg: _exit> python /Users/abramowi/Code/OpenSource/detect-secrets/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ py310: FAIL code 4 (1.43=setup[1.21]+cmd[0.06,0.16] seconds) evaluation failed :( (1.56 seconds) ```
msabramo
force-pushed
the
support-new-python-versions-and-upgrade-pytest-to-7.4.3
branch
from
1ceda22 to
3fff375
Compare
gpflaum
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Worked for me with Python 3.9 and 3.11.
Running tests now shows some additional warnings like the one below, where pytest warns that tests written for nose are deprecated:
tests/plugins/aws_key_test.py::TestAWSKeyDetector::test_analyze[aws_access_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEYa"-False]
/home/gpflaum/.local/lib/python3.9/site-packages/_pytest/fixtures.py:895: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
tests/plugins/aws_key_test.py::TestAWSKeyDetector::test_analyze[aws_access_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEYa"-False] is using nose-specific method: `setup(self)`
To remove this warning, rename it to `setup_method(self)`
See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
fixture_result = next(generator)
|
We added support for Python 3.10 and removed support for 3.7 in #724. We won't be supporting Python 3.11 yet as it's still in a bugfixes status. |
|
@lorenzodb1 You might be misinterpreting the meaning of bugfix status for Python releases. That designation is for stable, maintenance releases. It would be appropriate for detect-secrets to support those releases. 3.11 was released over a year ago. |
|
@gpflaum good call, I'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for new Python versions
What is the current behavior?
Tests run only up to Python 3.9
What is the new behavior (if this is a feature change)?
pytestfrom6.2.2to7.4.3(this was necessary to preventTypeError: required field "lineno" missing from aliaserrors that I was experiencing when testing with Python 3.10).Does this PR introduce a breaking change?
No.
Other information: