[BUGFIX] Fixed the get_cache_timeout within StructuredDataProviderMan…

…ager, introduced constant for the OverviewController request argument

Classes/Controller/AjaxController.php

@@ -34,7 +34,7 @@ public function saveScoresAction(
         return $this->saveScoresHandler->handle($request);
     }
 
-    public function promimentWordsAction(
+    public function prominentWordsAction(
         ServerRequestInterface $request
     ): ResponseInterface {
         return $this->prominentWordsHandler->handle($request);

Classes/Controller/OverviewController.php

@@ -11,6 +11,8 @@
 
 class OverviewController extends AbstractBackendController
 {
+    public const REQUEST_ARGUMENT = 'tx_yoastseo_yoast_yoastseooverview';
+
     public function __construct(
         protected ModuleTemplateFactory $moduleTemplateFactory,
         protected LanguageMenuFactory $languageMenuFactory,

Classes/Service/Overview/LanguageMenu/LanguageMenuFactory.php

@@ -11,6 +11,7 @@
 use TYPO3\CMS\Core\Site\SiteFinder;
 use TYPO3\CMS\Extbase\Mvc\RequestInterface;
 use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
+use YoastSeoForTypo3\YoastSeo\Controller\OverviewController;
 use YoastSeoForTypo3\YoastSeo\Service\Overview\Dto\LanguageMenuItem;
 use YoastSeoForTypo3\YoastSeo\Traits\BackendUserTrait;
 use YoastSeoForTypo3\YoastSeo\Traits\LanguageServiceTrait;
@@ -94,7 +95,7 @@ protected function getLanguageMenuItems(
                 ->setRequest($this->request)
                 ->setTargetPageUid($this->pageUid)
                 ->setArguments([
-                    'tx_yoastseo_yoast_yoastseooverview' => [
+                    OverviewController::REQUEST_ARGUMENT => [
                         'filter' => $filter,
                         'language' => $language->getLanguageId(),
                         'returnUrl' => $returnUrl,
@@ -116,6 +117,6 @@ protected function getLanguageMenuItems(
      */
     protected function getArguments(): array
     {
-        return $this->request->getArguments()['tx_yoastseo_yoast_yoastseooverview'] ?? $this->request->getArguments();
+        return $this->request->getArguments()[OverviewController::REQUEST_ARGUMENT] ?? $this->request->getArguments();
     }
 }

Classes/Service/Overview/OverviewService.php

@@ -7,6 +7,7 @@
 use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\Type\Bitmask\Permission;
 use TYPO3\CMS\Extbase\Mvc\RequestInterface;
+use YoastSeoForTypo3\YoastSeo\Controller\OverviewController;
 use YoastSeoForTypo3\YoastSeo\DataProviders\OverviewDataProviderInterface;
 use YoastSeoForTypo3\YoastSeo\Service\Overview\Dto\DataProviderRequest;
 use YoastSeoForTypo3\YoastSeo\Service\Overview\Dto\OverviewData;
@@ -93,7 +94,7 @@ protected function getDataProviderRequest(RequestInterface $request): DataProvid
     {
         return new DataProviderRequest(
             (int)($request->getQueryParams()['id'] ?? 0),
-            (int)($request->getQueryParams()['tx_yoastseo_yoast_yoastseooverview']['language'] ?? $request->getQueryParams()['language'] ?? 0),
+            (int)($request->getQueryParams()[OverviewController::REQUEST_ARGUMENT]['language'] ?? $request->getQueryParams()['language'] ?? 0),
             'pages'
         );
     }

Classes/StructuredData/StructuredDataProviderManager.php

@@ -6,11 +6,14 @@
 
 use Psr\Http\Message\ServerRequestInterface;
 use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
+use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Http\ApplicationType;
+use TYPO3\CMS\Core\Information\Typo3Version;
 use TYPO3\CMS\Core\Service\DependencyOrderingService;
 use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\TypoScript\TypoScriptService;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Frontend\Cache\CacheLifetimeCalculator;
 use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
 
 /**
@@ -82,8 +85,7 @@ public function getStructuredData(): array
                     $cacheIdentifier,
                     $data,
                     ['pageId_' . ($this->getTypoScriptFrontendController()->page['uid'] ?? $this->getTypoScriptFrontendController()->id)],
-                    // TODO: Fix this call, protected method since v13
-                    //$this->getTypoScriptFrontendController()->get_cache_timeout()
+                    $this->getCacheTimeout(),
                 );
             }
 
@@ -186,4 +188,29 @@ protected function getSourceComment(): string
     {
         return '<!-- This site is optimized with the Yoast SEO for TYPO3 plugin - https://yoast.com/typo3-extensions-seo/ -->';
     }
+
+    protected function getCacheTimeout(): int
+    {
+        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 13) {
+            return $this->getTypoScriptFrontendController()->get_cache_timeout();
+        }
+
+        $request = $GLOBALS['TYPO3_REQUEST'] ?? null;
+        if ($request === null) {
+            return 0;
+        }
+
+        $pageInformation = $request->getAttribute('frontend.page.information');
+        $typoScriptConfigArray = $request->getAttribute('frontend.typoscript')->getConfigArray();
+        $context = GeneralUtility::makeInstance(Context::class);
+
+        return GeneralUtility::makeInstance(CacheLifetimeCalculator::class)
+            ->calculateLifetimeForPage(
+                $pageInformation->getId(),
+                $pageInformation->getPageRecord(),
+                $typoScriptConfigArray,
+                0,
+                $context
+            );
+    }
 }

Configuration/Backend/AjaxRoutes.php

@@ -13,7 +13,7 @@
     ],
     'yoast_prominent_words' => [
         'path' => 'yoast/prominentwords',
-        'target' => AjaxController::class . '::promimentWordsAction',
+        'target' => AjaxController::class . '::prominentWordsAction',
     ],
     'yoast_internal_linking_suggestions' => [
         'path' => 'yoast/internallinkingsuggestions',