Merge pull request #20827 from Yoast/mixed-schema-output-when-both-co…

…mpany-and-person-information-is-stored-in-database
Yoast · Nov 8, 2023 · 3ffcdba · 3ffcdba
2 parents 72f8c3d + 04e5b86
commit 3ffcdba
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/generators/schema/person.php b/src/generators/schema/person.php
@@ -46,7 +46,7 @@ public function is_needed() {
 			return false;
 		}
 
-		return $this->context->site_represents === 'person' || $this->context->indexable->object_type === 'user';
+		return $this->context->site_represents === 'person';
 	}
 
 	/**

diff --git a/tests/unit/generators/schema/person-test.php b/tests/unit/generators/schema/person-test.php
@@ -393,20 +393,6 @@ public function test_is_shown_when_site_represents_person() {
 		$this->assertTrue( $this->instance->is_needed( $this->instance->context ) );
 	}
 
-	/**
-	 * Tests whether the person Schema piece is shown on author archive pages.
-	 *
-	 * @covers ::is_needed
-	 * @covers ::site_represents_current_author
-	 */
-	public function test_is_shown_on_author_archive_pages() {
-		$this->instance->context->indexable = (object) [
-			'object_type' => 'user',
-		];
-
-		$this->assertTrue( $this->instance->is_needed( $this->instance->context ) );
-	}
-
 	/**
 	 * Tests is not needed when the site represents an organization.
 	 *
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ public function is_needed() { @@
     			return false;
     		}
-    		return $this->context->site_represents === 'person' || $this->context->indexable->object_type === 'user';
+    		return $this->context->site_represents === 'person';
     	}
     	/**
@@ Expand Down @@