Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

84 improvements to the introduction modal #20787

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Oct 20, 2023

Context

  • Fix introduction modal styling and copy.

Summary

This PR can be summarized in the following changelog entry:

  • Adjust styling and copy of the AI introduction copy.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure Yoast SEO Premium is not active.
  • Edit a post or page.
  • Go to google preview
  • Click on Use AI button
  • Check AI introduction modal:
    • The upsell button should have the label: Unlock with Yoast SEO Premium
    • Check the line "NEW TO YOAST SEO PREMIUM 21.0` should have letter spacing of 0.8.
    • Check modal gradient should have the dark color not as the text background.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Improvements to the introduction modal

@vraja-pro vraja-pro added the changelog: other Needs to be included in the 'Other' category in the changelog label Oct 20, 2023
@vraja-pro vraja-pro force-pushed the 84-improvements-to-the-introduction-modal branch from 1eccb8b to ebaf17e Compare October 23, 2023 14:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6615358256

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 49.106%

Totals Coverage Status
Change from base Build 6610393037: 0.02%
Covered Lines: 13135
Relevant Lines: 26748

💛 - Coveralls

@thijsoo thijsoo added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: other Needs to be included in the 'Other' category in the changelog labels Oct 24, 2023
@thijsoo thijsoo added this to the 21.6 milestone Oct 24, 2023
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit 1e8d4d1 into trunk Oct 24, 2023
34 checks passed
@thijsoo thijsoo deleted the 84-improvements-to-the-introduction-modal branch October 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants