-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add introductions seen route #20791
Merged
vraja-pro
merged 7 commits into
feature/ai-plugin-default-on
from
141-adapt-ai-introduction-modal-when-feature-is-on-by-default-premium
Oct 26, 2023
Merged
Add introductions seen route #20791
vraja-pro
merged 7 commits into
feature/ai-plugin-default-on
from
141-adapt-ai-introduction-modal-when-feature-is-on-by-default-premium
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface to access whether the user has seen an introduction
To be able to set whether an introduction was seen
Remove or deprecate name
igorschoester
added
innovation
Innovative issue. Relating to performance, memory or data-flow.
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
labels
Oct 24, 2023
Pull Request Test Coverage Report for Build 6653889266
💛 - Coveralls |
thijsoo
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question 🚧
src/introductions/infrastructure/introductions-seen-repository.php
Outdated
Show resolved
Hide resolved
to include `all` for a clearer distinction between the multiple and single methods
thijsoo
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
ACC ✅ |
vraja-pro
deleted the
141-adapt-ai-introduction-modal-when-feature-is-on-by-default-premium
branch
October 26, 2023 12:24
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
innovation
Innovative issue. Relating to performance, memory or data-flow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
name
toid
as that seems like a better name for a "unique name"[\w-]+
matcher for the introduction ID in the route URL, as opposed to a query param without such regex limits. Mainly because this is more REST styleTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
/wp-json/yoast/v1/introductions/INTRO_ID/seen
where INTRO_ID is the ID of your introductionis_seen
to indicate whether you have seen it or not, if you skip this it will default to seen_yoast_wpseo_introductions
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/141