Skip to content

Remove makePublic from non-public classes #20794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove makePublic from non-public classes #20794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/introductions/application/ai-generate-titles-and-descriptions-introduction-upsell.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
* Represents the introduction for the AI generate titles and introduction upsell.
*
* @phpcs:disable Yoast.NamingConventions.ObjectNameDepth.MaxExceeded
*
* @makePublic
*/
class Ai_Generate_Titles_And_Descriptions_Introduction_Upsell implements Introduction_Interface {

Expand Down
2 changes: 0 additions & 2 deletions src/introductions/application/introductions-collector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

/**
* Manages the collection of introductions.
*
* @makePublic
*/
class Introductions_Collector {

Expand Down
2 changes: 0 additions & 2 deletions src/introductions/user-interface/wistia-embed-permission-route.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

/**
* Registers a route to offer get/set of the wistia embed permission for a user.
*
* @makePublic
*/
class Wistia_Embed_Permission_Route implements Route_Interface {

Expand Down
2 changes: 0 additions & 2 deletions src/promotions/application/promotion-manager-interface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

/**
* Interface for the promotion manager.
*
* @makePublic
*/
interface Promotion_Manager_Interface {

Expand Down
2 changes: 0 additions & 2 deletions src/promotions/domain/black-friday-checklist-promotion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

/**
* Class to manage the Black Friday checklist promotion.
*
* @makePublic
*/
class Black_Friday_Checklist_Promotion extends Abstract_Promotion implements Promotion_Interface {

Expand Down
2 changes: 0 additions & 2 deletions src/promotions/domain/black-friday-promotion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

/**
* Class to manage the Black Friday promotion.
*
* @makePublic
*/
class Black_Friday_Promotion extends Abstract_Promotion implements Promotion_Interface {

Expand Down