Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update copy in ai introduction modal for products #20806

Merged
merged 4 commits into from
Oct 30, 2023
Merged

update copy in ai introduction modal for products #20806

merged 4 commits into from
Oct 30, 2023

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Oct 27, 2023 •
edited
Loading

Context

  • Update copy for ai introduction modal on product pages.

Summary

This PR can be summarized in the following changelog entry:

  • Update copy for ai introduction modal on product pages.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install WooCommerce

  • Make sure Yoast Premium is not active

  • Create or Edit a product

  • Go to Google preview

  • Click on Use AI

  • Check the New to text and the title and description are as follow:

    • New to Text: "New to Yoast SEO Premium + Yoast WooCommerce SEO"
    • Title: "Generate product titles & descriptions with AI!"
    • Description: "Speed up your workflow with generative AI. Get high-quality product title and description suggestions for your search and social appearance. Learn more"

  • Repeat those steps when:

    • Premium is active and WooCommerce SEO not active
    • Premium is not active and WooCommerce SEO is active

  • Edit a post that is not a product

  • Check the New to text and the title and description are as follow:

    • New to Text: "New to Yoast SEO Premium 21.0"
    • Title: "Generate titles & descriptions with Yoast AI!"
    • Description: "Speed up your workflow with generative AI. Get high-quality title and description suggestions for your search and social appearance. Learn more"

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/1132

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 27, 2023
enricobattocchi
enricobattocchi requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Premium version number should not be there on the WooSEO upsell

packages/js/src/shared-admin/components/ai-generate-titles-and-descriptions-upsell.js Outdated
__( "New to %1$s", "wordpress-seo" ),
"Yoast SEO Premium"
) }
{ newToText }
</span>
&nbsp;
<span className="yst-uppercase yst-text-slate-700">21.0</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be there only when displaying "New to Yoast SEO Premium"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

igorschoester
igorschoester requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC 🏗️

The case with no Premium but with Woo add-on is missing the product copy changes (design)

igorschoester
igorschoester approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AC ✅

@igorschoester igorschoester added this to the feature/enable-ai-products milestone Oct 30, 2023
@igorschoester igorschoester merged commit 992f0cc into feature/enable-ai-products Oct 30, 2023
15 checks passed
@igorschoester igorschoester deleted the 1132-minor-discrepancy-yoast-ai-for-products-upsell-modal branch October 30, 2023 11:54
@mhkuu mhkuu mentioned this pull request Oct 31, 2023
Merged
18 tasks
@mhkuu mhkuu modified the milestones: feature/enable-ai-products, 21.6 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricobattocchi enricobattocchi enricobattocchi requested changes

@igorschoester igorschoester igorschoester approved these changes

Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
21.6
Development

Successfully merging this pull request may close these issues.
4 participants
@vraja-pro @enricobattocchi @igorschoester @mhkuu