Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

395 outdated translations #21940

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jan 2, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes outdated translation.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Got to posts overview page, and hover over the icons for internal and external links in the table.

  • Check you don't see the text "See "Yoast Columns" text in the help tab for more info."

  • Check you see the text 'Number of outgoing internal links in this post.' for out going icon and 'Number of internal links linking to this post.' for internal links.
    Screenshot 2025-01-02 at 12 22 15

  • Enable Wincher integration on the Yoast integration page. Do not connect to Wincher.

  • Go to the site dashboard and check the Wincher card. In the text before the table, there should be a link for the word Wincher:
    Screenshot 2025-01-02 at 12 54 39

  • Click on the link and make sure it redirects to Wincher.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Outdated translations

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jan 2, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0018702d70d5f3ca752d9fb3db4490210e849a3d

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/integrations/admin/link-count-columns-integration.php 0 2 0.0%
Totals Coverage Status
Change from base Build 01c6afdf2feaddb2d89d45d0f50dfbce38e34b57: 0.0%
Covered Lines: 30105
Relevant Lines: 55467

💛 - Coveralls

@vraja-pro vraja-pro changed the base branch from trunk to feature/plugin-fixes January 2, 2025 10:34
@vraja-pro vraja-pro added this to the feature/plugin-fixes milestone Jan 2, 2025
@vraja-pro vraja-pro added the UI change PRs that result in a change in the UI label Jan 2, 2025
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit c85ba18 into feature/plugin-fixes Jan 6, 2025
36 checks passed
@igorschoester igorschoester deleted the 395-outdated-translations branch January 6, 2025 12:03
@pls78 pls78 modified the milestones: feature/plugin-fixes, 24.4 Jan 7, 2025
This was referenced Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants