Feat/update layout redirects #22319

kyrylo-polozenko-newfold · 2025-05-28T14:04:46Z

Context

This PR introduces the initial structure for the Redirections feature in the application. The goal is to establish a foundation for managing and displaying redirections within the admin interface.

Summary

This PR can be summarized in the following changelog entry:

Adds the basic structure and UI for the Redirections page in the WordPress SEO plugin.
Some components were also moved to the shared layer and reused on the settings and redirects pages

UI changes

This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

React frontend structure

packages/js/src/components/SchemaTab.js

packages/js/src/components/modals/WincherUpgradeCallout.js

...es/js/src/first-time-configuration/tailwind-components/steps/social-profiles/social-input.js

packages/js/src/general/components/alerts-list.js

packages/js/src/general/components/sidebar-layout.js

packages/js/src/redirects/components/filter-controls.js

packages/js/src/redirects/app.js

packages/js/src/shared-admin/components/search/search.js

enricobattocchi · 2025-05-29T14:29:05Z

Hey @kyrylo-polozenko-newfold, my teammate @vraja-pro left a first round of comments above
One thing that's not clear to us is that in some files you have added the default values for params for unrelated components, I suppose it was because eslint was complaining? If so, you should probably try to fix any error/warning in the components you are introducing to avoid conflicts - we are in the process to fix the other warnings so there could be some overlap...

kyrylo-polozenko-newfold · 2025-05-30T09:06:19Z

Hey @enricobattocchi
yes you are right I made these changes because I had warnings on eslint, I did a rollback

packages/js/src/redirects/components/filter-controls.js

packages/js/src/redirects/components/menu.js

packages/js/src/redirects/components/route-error-fallback.js

packages/js/src/redirects/routes/redirect-method.js

packages/js/src/redirects/routes/regex-redirects.js

vraja-pro · 2025-06-03T08:56:46Z

packages/js/src/shared-admin/components/search/search.js

+	return <>
+		<Button
+			id={ buttonId }
+			type="button"


type button is the default

vraja-pro · 2025-06-03T08:59:32Z

packages/js/src/shared-admin/components/search/search.js

+			id={ buttonId }
+			type="button"
+			variant="secondary"
+			className="yst-w-full yst-flex yst-items-center yst-justify-start yst-font-normal yst-text-sm yst-leading-6 yst-text-slate-500 yst-rounded-md yst-border-slate-300 yst-shadow-sm yst-py-1.5 yst-pl-2 yst-pr-3"


I believe some of the classes here are already part of the secondary variant and the button component.

vraja-pro · 2025-06-09T06:21:33Z

packages/js/src/redirects/routes/redirects.js

+								as={ TextField }
+								type="text"
+								name="newURL"
+								id="input-new_url"


Suggested change

id="input-new_url"

id="yst-input-new_url"

vraja-pro · 2025-06-09T06:21:44Z

packages/js/src/redirects/routes/redirects.js

+								as={ TextField }
+								type="text"
+								name="oldURL"
+								id="input-old_url"


Suggested change

id="input-old_url"

id="yst-input-old_url"

vraja-pro · 2025-06-09T06:21:53Z

packages/js/src/redirects/routes/redirects.js

+								as={ SelectField }
+								type="select"
+								name="redirectType"
+								id="input-redirect_type"


Suggested change

id="input-redirect_type"

id="yst-input-redirect_type"

vraja-pro · 2025-06-09T06:23:45Z

packages/js/src/shared-admin/components/form/form-layout.js

+					<div className="yst-bg-slate-50 yst-border-slate-200 yst-border-t yst-rounded-b-lg">
+						<div className="yst-flex yst-align-middle yst-space-x-3 rtl:yst-space-x-reverse yst-p-8">
+							<Button
+								id="button-submit-settings"


Suggested change

id="button-submit-settings"

id="yst-button-submit-settings"

packages/js/src/shared-admin/components/form/form-layout.js

packages/js/src/shared-admin/components/search/search.js

packages/js/src/redirects/components/menu.js

vraja-pro

CR ✅

kyrylo-polozenko-newfold added UI change PRs that result in a change in the UI changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels May 28, 2025

enricobattocchi added this to the feature/redirection20 milestone May 29, 2025

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/components/SchemaTab.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/components/modals/WincherUpgradeCallout.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

...es/js/src/first-time-configuration/tailwind-components/steps/social-profiles/social-input.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/general/components/alerts-list.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/general/components/sidebar-layout.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/redirects/components/filter-controls.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/redirects/components/filter-controls.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/redirects/app.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed May 29, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

kyrylo-polozenko-newfold requested a review from vraja-pro May 30, 2025 09:10

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/filter-controls.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/filter-controls.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/filter-controls.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/menu.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/route-error-fallback.js Outdated Show resolved Hide resolved

vraja-pro self-assigned this Jun 3, 2025

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/route-error-fallback.js Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/components/route-error-fallback.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/routes/redirect-method.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

packages/js/src/redirects/routes/regex-redirects.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 3, 2025

View reviewed changes

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/form/form-layout.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 9, 2025

View reviewed changes

packages/js/src/shared-admin/components/search/search.js Outdated Show resolved Hide resolved

vraja-pro assigned kyrylo-polozenko-newfold and unassigned vraja-pro Jun 9, 2025

fix: resolve comments

1bb1dd9

kyrylo-polozenko-newfold requested a review from vraja-pro June 10, 2025 09:50

vraja-pro assigned vraja-pro and unassigned kyrylo-polozenko-newfold Jun 10, 2025

vraja-pro reviewed Jun 10, 2025

View reviewed changes

packages/js/src/redirects/components/menu.js Outdated Show resolved Hide resolved

vraja-pro reviewed Jun 10, 2025

View reviewed changes

packages/js/src/redirects/components/menu.js Outdated Show resolved Hide resolved

vraja-pro assigned kyrylo-polozenko-newfold and unassigned vraja-pro Jun 10, 2025

fix: add SwitchHorizontalIcon to menu

8b7f26a

kyrylo-polozenko-newfold requested a review from vraja-pro June 10, 2025 13:44

vraja-pro approved these changes Jun 11, 2025

View reviewed changes

vraja-pro merged commit cb6e195 into feature/redirection20 Jun 11, 2025
36 of 37 checks passed

vraja-pro deleted the feat/update-layout-redirects branch June 11, 2025 09:40

Feat/update layout redirects #22319

Feat/update layout redirects #22319

Uh oh!

Conversation

kyrylo-polozenko-newfold commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Summary

UI changes

Impact check

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enricobattocchi commented May 29, 2025

Uh oh!

kyrylo-polozenko-newfold commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vraja-pro Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

vraja-pro Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

vraja-pro Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

vraja-pro Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

vraja-pro Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

vraja-pro Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vraja-pro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kyrylo-polozenko-newfold commented May 28, 2025 •

edited

Loading