Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cythonized most time consuming operator #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SoluMilken
Copy link
Contributor

@SoluMilken SoluMilken commented Feb 13, 2019

Profiling

Original

...Profiling Transform 10000
...Profiling Transform 10000 done in 0:00:02.622399
...Profiling Transform Sequence 10000
...Profiling Transform Sequence 10000 done in 0:00:01.994809
  • details
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)                                            
    10000    0.367    0.000    1.727    0.000 /home/en/uttut/uttut/pipeline/ops/token_to_index.py:66(_gen_forward_replacement_group)  
1060000/530000    0.357    0.000    0.501    0.000 uttut/pipeline/edit/replacement.pyx:81(add)                        
    30000    0.312    0.000    0.554    0.000 uttut/pipeline/edit/replacement.pyx:172(_sort_replacements)                 
    40000    0.291    0.000    0.388    0.000 uttut/pipeline/edit/validation.pyx:14(_validate_disjoint_in_c)
    10000    0.257    0.000    1.117    0.000 /home/en/uttut/uttut/pipeline/edit/str2lst.py:23(gen_span_group)
800000/400000    0.230    0.000    0.338    0.000 uttut/pipeline/edit/span.pyx:45(add)        
    10000    0.217    0.000    0.466    0.000 uttut/pipeline/edit/label_propagation.pyx:118(reduce_by_span_group)
100000/60000    0.187    0.000    1.118    0.000 uttut/pipeline/edit/replacement.pyx:98(done)                   
    30000    0.181    0.000    0.181    0.000 {built-in method builtins.sum}                               
    60000    0.178    0.000    0.239    0.000 uttut/pipeline/edit/utils.pyx:6(_transform_sequence)

After

...Profiling Transform 10000
...Profiling Transform 10000 done in 0:00:02.215317
...Profiling Transform Sequence 10000
...Profiling Transform Sequence 10000 done in 0:00:01.748307

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #90 into master will decrease coverage by 0.97%.
The diff coverage is 72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   95.07%   94.09%   -0.98%     
==========================================
  Files          51       51              
  Lines        1524     1576      +52     
  Branches      114      108       -6     
==========================================
+ Hits         1449     1483      +34     
- Misses         68       86      +18     
  Partials        7        7
Impacted Files Coverage Δ
uttut/pipeline/step.py 100% <100%> (ø) ⬆️
uttut/pipeline/ops/token_to_index.pyx 89.13% <50%> (ø)
uttut/pipeline/ops/base.pyx 74.5% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56abac...661cdef. Read the comment docs.

@stegben
Copy link
Contributor

stegben commented Feb 14, 2019

WHat is the most time consuming operator?

@SoluMilken
Copy link
Contributor Author

token_to_index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants