query optimization & adds indexes

src/Models/ShortUrl.php

@@ -114,18 +114,15 @@ public function scopeExpiringInDays($query, $days)
 
     public function scopeHasTracing($query, $search)
     {
-        $query->whereHas('tracing')
-            ->whereIn('short_urls.id', function ($subQuery) use ($search) {
-                $subQuery->from('short_url_tracings')
-                    ->where(function ($subWhereQuery) use ($search) {
-                        $subWhereQuery->where('short_url_tracings.utm_source', 'like', '%'.$search.'%')
-                            ->orWhere('short_url_tracings.utm_medium', 'like', '%'.$search.'%')
-                            ->orWhere('short_url_tracings.utm_campaign', 'like', '%'.$search.'%')
-                            ->orWhere('short_url_tracings.utm_content', 'like', '%'.$search.'%')
-                            ->orWhere('short_url_tracings.utm_term', 'like', '%'.$search.'%');
-                    })
-                    ->select('short_url_tracings.short_url_id');
-            });
+        $query->join('short_url_tracings', 'short_urls.id', '=', 'short_url_tracings.short_url_id')
+            ->where(function ($subWhereQuery) use ($search) {
+                $subWhereQuery->where('short_url_tracings.utm_source', 'like', '%'.$search.'%')
+                    ->orWhere('short_url_tracings.utm_medium', 'like', '%'.$search.'%')
+                    ->orWhere('short_url_tracings.utm_campaign', 'like', '%'.$search.'%')
+                    ->orWhere('short_url_tracings.utm_content', 'like', '%'.$search.'%')
+                    ->orWhere('short_url_tracings.utm_term', 'like', '%'.$search.'%');
+            })
+            ->whereNull('short_url_tracings.deleted_at'); // Handle soft deletes if necessary
 
         return $query;
     }

src/Utility/Migrations/2024_08_20_163744_add_indexes_for_url_clicks.php

@@ -0,0 +1,24 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('short_url_clicks', function (Blueprint $table) {
+            $table->index('short_url_id');
+            $table->index('location_id');
+            $table->index('outcome_id');
+
+            $table->index(['short_url_id', 'outcome_id'], 'clicks_url_outcome_index');
+        });
+    }
+};

src/Utility/Migrations/2024_08_20_163744_add_indexes_for_url_tracing.php

@@ -0,0 +1,20 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('short_url_tracings', function (Blueprint $table) {
+            $table->index(['utm_source', 'utm_medium', 'utm_campaign', 'utm_content', 'utm_term'], 'utm_composite_index');
+        });
+    }
+};