Fix SyntaxWarning #286
Closed
Fix SyntaxWarning #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remove an invalid escape sequence.
|
Could you elaborate on the python version compatibility of the old and new syntax?
Sent from Proton Mail Android
…-------- Original Message --------
On 22/10/2024 02:04, Emmanuel Arias wrote:
This commit remove an invalid escape sequence.
---------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#286
Commit Summary
- [66f036d](66f036d) Fix SyntaxWarning
File Changes
([1 file](https://github.com/YosysHQ/apicula/pull/286/files))
- M [apycula/gowin_pack.py](https://github.com/YosysHQ/apicula/pull/286/files#diff-b026fe7bf1dfabe852a44f1bd1762e1a2d2f6cbca7863da3032d81b87062e236) (2)
Patch Links:
- https://github.com/YosysHQ/apicula/pull/286.patch
- https://github.com/YosysHQ/apicula/pull/286.diff
—
Reply to this email directly, [view it on GitHub](#286), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AABJFIPBRK6QMRQRSP5T6ZTZ4WJBTAVCNFSM6AAAAABQLIOSICVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDGOJSGA2DGMY).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Hi! Sorry, I don't know what you mean, but invalid escape sequence were deprecated in py3.6[0]. In python3.12 the DeprecationWarning was replaced by a SyntaxWarning[1]. This commit convert the literal string in a raw. [0] python/cpython#98401 |
|
Thanks. I just found my own answer, the fr combination is as old as format strings themselves so there is no backwards compatibility problem. Lgtm!
Sent from Proton Mail Android
…-------- Original Message --------
On 25/10/2024 03:18, Emmanuel Arias wrote:
Hi!
Sorry, I don't know what you mean, but invalid escape sequence were deprecated in py3.6[0]. In python3.12 the DeprecationWarning was replaced by a SyntaxWarning[1].
This commit convert the literal string in a raw.
[0] [python/cpython#98401](python/cpython#98401)
[1] https://docs.python.org/3/whatsnew/3.12.html#other-language-changes
—
Reply to this email directly, [view it on GitHub](#286 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AABJFIIJJDZMBYRARWSMC6TZ5GL5LAVCNFSM6AAAAABQLIOSICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGYYTIMZWHA).
You are receiving this because you commented.Message ID: ***@***.***>
|
|
I forgot about this and meanwhile it got fixed in #304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove an invalid escape sequence.
Error originally reported here [0]
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085325