Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Use upstream BoostConfig.cmake instead of cmake's own #1387

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

gatecat
Copy link
Member

@gatecat gatecat commented Oct 22, 2024

Fixes #1384

This seems to be a very old workaround forcing it to use the old approach that hopefully isn't needed any more on any of the systems we support.

Signed-off-by: gatecat <gatecat@ds0.me>
@whitequark
Copy link
Member

Oh, this might break Wasm.

@gatecat
Copy link
Member Author

gatecat commented Oct 22, 2024

I can make it conditional on non-WASM builds?

@whitequark
Copy link
Member

Let's just merge it and if it breaks I'll fix it in the Wasm scripts.

@gatecat gatecat merged commit f36a657 into master Oct 22, 2024
16 checks passed
@gatecat gatecat deleted the gatecat/new-boost-cmake branch October 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMakeLists.txt as written will not find Boost headers with old policy in recent Boost/CMake versions
2 participants