handle some cases of hdlname attribute on private objects #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakengelhardt
added
the
merge-before-release
jix
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Supersedes #4842: There are currently too many cases that don't respect this invariant, so defer the enforcement for now.
Explain how this is achieved.
For the next release, just fix the cases already identified. In the case of an object with a private name and an
hdlnameattribute, allowparse_hdlname()/parse_scopename()to act as if it was a corresponding scopename attribute (ignoring the final entry). The behaviour should be unchanged for other cases.If applicable, please suggest to reviewers how they can test the change.