🐛 fix: ditch lambdas as criteria

YounesOMK · Dec 21, 2023 · 7e83ff5 · 7e83ff5
1 parent 9a1f106
commit 7e83ff5
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/metricheq/evaluation/models.py b/metricheq/evaluation/models.py
@@ -7,16 +7,10 @@
 class Metric(BaseModel):
     value: Optional[Union[int, float, bool]]
 
-    def satisfies(self, criterion) -> bool:
+    def satisfies(self, criterion: "Criterion") -> bool:
         if self.value is None:
             return False
-
-        if callable(criterion):
-            return criterion(self.value)
-        elif isinstance(criterion, Criterion):
-            return criterion.is_satisfied_by(self)
-        else:
-            raise ValueError("Criterion must be a callable or an instance of Criterion")
+        return criterion.is_satisfied_by(self)
 
     def satisfies_all(self, criteria: List["Criterion"]) -> bool:
         if self.value is None: