Skip to content

fix: Race condition when reporting errors to the user #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuKitsune merged 2 commits into from
Jan 17, 2026
Merged

fix: Race condition when reporting errors to the user #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
227372d
fix: Race condition when reporting errors to the user
YuKitsune Jan 17, 2026
8ebf83f
fix: Log before displaying to the user
YuKitsune Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions source/CPDLCPlugin/Plugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,25 +175,28 @@ void NetworkDisconnected(object sender, EventArgs e)

public static void AddError(Exception exception)
{
TryAddErrorInternal(exception);
Log.Error(exception, "An error has occurred");
TryAddErrorInternal(exception);
}

public static void AddError(Exception exception, string message)
{
TryAddErrorInternal(exception);
Log.Error(exception, message);
TryAddErrorInternal(exception);
}

static void TryAddErrorInternal(Exception exception)
{
// Don't flood the error window with the same message over and over again
if (ErrorMessages.TryGetValue(exception.Message, out var lastShown) &&
DateTimeOffset.Now - lastShown <= TimeSpan.FromMinutes(1))
return;
lock (ErrorMessages)
{
// Don't flood the error window with the same message over and over again
if (ErrorMessages.TryGetValue(exception.Message, out var lastShown) &&
DateTimeOffset.Now - lastShown <= TimeSpan.FromMinutes(1))
return;

Errors.Add(exception, Name);
ErrorMessages.Add(exception.Message, DateTimeOffset.Now);
Errors.Add(exception, Name);
ErrorMessages.Add(exception.Message, DateTimeOffset.Now);
}
}

void ConfigureTheme()
Expand Down
Loading