add the schema link in toml files

[OniriCorpe]

notes:

• graveyard.toml does not have a schema -> fixed
• antifeatures.toml does not have a schema -> fixed
• Additional properties are not allowed ('draft' was unexpected) errors for wishlist.toml -> fixed

PR status: ready

[Psycojoker]

Are those schemas used by linter tools? Do we have a CI job that used them before merging or do we need one?

[OniriCorpe]

Are those schemas used by linter tools? Do we have a CI job that used them before merging or do we need one?

yes it's used by an automatic linter, but only for apps.toml

apps/tools/catalog_linter.py

Lines 14 to 19 in 6874158

	def validate_schema() -> Generator[str, None, None]:
	with open(REPO_APPS_ROOT / "schemas" / "apps.toml.schema.json", encoding="utf-8") as file:
	apps_catalog_schema = json.load(file)
	validator = jsonschema.Draft202012Validator(apps_catalog_schema)
	for error in validator.iter_errors(get_catalog()):
	yield f"at .{'.'.join(error.path)}: {error.message}"

it's also used by my linter in my IDE, so i can easilly spot errors like:

Additional properties are not allowed ('draft' was unexpected) errors for wishlist.toml

and fix them by hand

even if they're not used by an automatic CI, it's a good enhancement i think:

• it brings standardization (all our .toml files have their associated schema)
• it's good practice for toml
• we can quickly see manually what is broken, it's not perfect but better than nothing
• the new schemas could be used in an automatic linter one day in the future

[Psycojoker]

even if they're not used by an automatic CI, it's a good enhancement i think

I think too, I'm interested about how to automatized it and adding it where it's useful like in some CI jobs or equivalent