readme-generator: only pick files (no folder) on the root of 'screenshots' #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OniriCorpe
force-pushed
the
readme-generator_better-screenshot-handling
branch
from
6250de8 to
8c777e2
Compare
…hange with language
2 tasks
Salamandar
reviewed
Mar 13, 2024
Salamandar
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
if a subfolder exists, it is used as a screenshot file:
this is obviously wrong
The solution
readme-generatorto only pick actual files (no folder) on the root of the 'screenshots' directoryscreenshotscode part to only run it once, since it do not change with languagethis also permit to create subfolders to store pictures only used in docs
PR status
ready to review