tools: add get_apps_repo.py, a lib that allows to pass --apps-repo or --apps-dir to tools #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamandar
force-pushed
the
tools_apps_arg
branch
4 times, most recently
from
5b2b90f to
f61e49d
Compare
Salamandar
force-pushed
the
tools_apps_arg
branch
from
01b3978 to
db7cd6f
Compare
Salamandar
force-pushed
the
tools_apps_arg
branch
13 times, most recently
from
bc29abd to
e4c46d0
Compare
Salamandar
force-pushed
the
tools_apps_arg
branch
2 times, most recently
from
a813675 to
d0d915a
Compare
alexAubin
reviewed
Sep 12, 2024
… --apps-dir to tools or the env var YNH_APPS_DIR
Salamandar
force-pushed
the
tools_apps_arg
branch
from
d0d915a to
f6566c7
Compare
Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr this is a step towards splitting this repository in half : apps shouldn't reference APPS_DIR anymore, they require a --apps-repo (clone it to a temp dir) or --apps-dir (an already cloned repo).
Tools:
apps_caches.py-> only reads catalog, both are relevantcatalog_linter.py-> only local repo is relevantlist_builder.py-> reads catalog, but uses logos -> only local repo is relevantsave_added_dates.py-> only local repo relevantautopatch-> both is relevantautoupdate_app_sources-> only reads catalog, both are relevantreadme_generator-> reads catalog, both are relevantupdate_apps_level-> convertedwebhooks-> no