Fix: Use KeyBinding instead of hardcoded K key in command window#24
Open
tember8003 wants to merge 1 commit intoYuvDwi:mainfrom
Open
Fix: Use KeyBinding instead of hardcoded K key in command window#24tember8003 wants to merge 1 commit intoYuvDwi:mainfrom
tember8003 wants to merge 1 commit intoYuvDwi:mainfrom
Conversation
Maxencehabar
approved these changes
Dec 5, 2025
Maxencehabar
left a comment
There was a problem hiding this comment.
Perfect fix for being able to type K in chat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: user key binding in command window
When the user changes the toggle GUI key binding from K to another key (e.g., apostrophe), the command window would still close when pressing K. The new key binding would only work to open the window, but K would always close it.
SteveOverlayScreen.javawas checking for hardcodedkeyCode == 75(K key) instead of using the configured key binding.-> Replaced hardcoded
keyCode == 75check withKeyBindings.TOGGLE_GUI.matches(keyCode, scanCode)Tested
Fixes the issue where key binding configuration was inconsistent between opening and closing the GUI.