Fix install deps, move nfc_uid to __init__, remove shell commands #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as above Update __init__.py, to remove system shell from running pip... Update pyproject.toml to add dependencies for installing, not as build deps.
|
Not sure yet if I implement this as I am planning to rework some of my embarrassing old and ineffective code. When I have time. |
|
Not a fan of the code in the init. But I will import the nfc_uid to the init which comes out to the same stuff. Also will implement the install fixes |
|
Check the new 0.5.1 branch out. If nothing comes up I will merge and release withing the week or so. Depends on time |
|
No response sol I will close it for now. Reopen an issue or pull request if you want additions in 0.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.