CFWEB-177 Update Styleguide app to Angular 18 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-includes update to TypeScript 5.4 - includes update to new Angular build system - includes update to @angular-eslint/schematics@rc-v18 (final not ready yet)
|
The triggered build does fail on this pull request, this happens because of outdated configurations for wdio, which will be fixed in this PR. |
added 2 commits
August 5, 2024 16:43
…5-Angular-18-Update # Conflicts: # package-lock.json
Azaraky
reviewed
Sep 10, 2024
| imports: [], | ||
| providers: [ | ||
| RecommendationService, | ||
| provideHttpClient(withInterceptorsFromDi()), |
There was a problem hiding this comment.
I found this on the official Angular page for "withInterceptorsFromDi".
https://angular.dev/api/common/http/withInterceptorsFromDi?tab=description
Prefer withInterceptors and functional interceptors instead, as support for DI-provided interceptors may be phased out in a later release.
Maybe you should check this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: