Cfweb 121 interoperate @defer and migrate control structures #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res to the new one
…res to the new one
…res to the new one
Kancso0
requested review from
sbley,
speti05,
MariusAquarius,
LBraeschke and
Azaraky
speti05
approved these changes
Aug 27, 2024
Azaraky
approved these changes
Sep 10, 2024
LBraeschke
requested changes
Sep 25, 2024
| @@ -17,6 +24,8 @@ export class ProductComponent { | |||
| @Input() product: Product; | |||
| @Output() productImageClicked: EventEmitter<void> = new EventEmitter<void>(); | |||
|
|
|||
| constructor(public elementRef: ElementRef) {} | |||
There was a problem hiding this comment.
why do we need the elementRef here?
| export class ViewportService { | ||
| public isInViewport(elementRef: ElementRef<any>): Observable<boolean> { | ||
| return new Observable((observer) => { | ||
| const element = elementRef?.nativeElement.getElementsByTagName('p')[0]; |
There was a problem hiding this comment.
I would suggest that this element is provided as an argument instead of doing here the query (:
| return this.displayableContentSections[index / 3]; | ||
| } | ||
|
|
||
| public ngAfterViewInit(): void { |
There was a problem hiding this comment.
why cant we use the on-viewport here? https://angular.dev/guide/defer#on-viewport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.