Bug/600319

[t-tkachenko]

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

• [x ] I have read the CONTRIBUTING document
• [x ] My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• [x ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• Breaking change (fix or feature that would cause existing functionality to change)
• My change requires a change to the documentation
• [ x] I have updated the documentation accordingly
• I have added tests to cover my changes
• [ x] All new and existing tests passed

Description

Carousel bug fixed: (#600319: see details here) iBase Announcements | Navigation dots shown on slider even for 1 page

[CLAassistant]

All committers have signed the CLA.

[teberl]

Thanks @t-tkachenko for the contribution.
IMHO it would be preferable if the component exposes a property, like pagination or bullets which is of type boolean that way the parent could handle the visibility itself. Default would be true, to not break existing behaviour.
That approach would make it more flexible to use and also enable the option to completly disable the bullet points if desired.

Maybe this is also not a bug, i feel it is more like a feature request for the component?

[t-tkachenko]

Thanks @t-tkachenko for the contribution. IMHO it would be preferable if the component exposes a property, like pagination or bullets which is of type boolean that way the parent could handle the visibility itself. Default would be true, to not break existing behaviour. That approach would make it more flexible to use and also enable the option to completly disable the bullet points if desired.

Maybe this is also not a bug, i feel it is more like a feature request for the component?

In the current state it is definitely a bug. If Carousel has only one Page it means that it's no places (and points) to navigate with bullets, arrows, etc. So navigation facilities should be hidden.
Your proposal is a feature allowing parent component to hide Bullets on demand no matter the Pages count.
However it's not relied to this bug.

I can add your idea implementation here if you want though.

[benbouba]

This repository is being archived, and all PRs have been closed as part of the process.