This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 383
feat(apollox): ApolloX Liquidity Pool #2627
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f68e76
to
4a94877
Compare
wpoulin
reviewed
Apr 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you aren't done yet, but here's a few tips to help you out
src/apps/apollox/binance-smart-chain/apollox.alp.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
src/apps/apollox/binance-smart-chain/apollox.alp.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
src/apps/apollox/binance-smart-chain/apollox.alp.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
wpoulin
reviewed
May 1, 2023
async getLabel( | ||
params: GetDisplayPropsParams<Alp, DefaultDataProps, DefaultContractPositionDefinition>, | ||
): Promise<string> { | ||
return `${params.contract.symbol()}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you want to return the result of a function, you don't need to use string interpolation
You can do
return param.contract.symbol()
You could even do something like
async getLabel(
{ contract }: GetDisplayPropsParams<Alp, DefaultDataProps, DefaultContractPositionDefinition>,
): Promise<string> {
return contract.symbol();
}
```
src/apps/apollox/binance-smart-chain/apollox.alp-stacking.contract-position-fetcher copy.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new ApolloX app
Fetch ApolloX Liquidity Pool positions
Currently in draft (not ready for review yet)