Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(apollox): ApolloX Liquidity Pool #2627

Closed
wants to merge 6 commits into from
Closed

Conversation

icyfry
Copy link

@icyfry icyfry commented Apr 29, 2023

Description

Add a new ApolloX app

Fetch ApolloX Liquidity Pool positions

Currently in draft (not ready for review yet)


@icyfry icyfry force-pushed the apollox branch 2 times, most recently from 6f68e76 to 4a94877 Compare April 29, 2023 11:40
Copy link
Contributor

@wpoulin wpoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you aren't done yet, but here's a few tips to help you out

async getLabel(
params: GetDisplayPropsParams<Alp, DefaultDataProps, DefaultContractPositionDefinition>,
): Promise<string> {
return `${params.contract.symbol()}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you want to return the result of a function, you don't need to use string interpolation
You can do
return param.contract.symbol()

You could even do something like

  async getLabel(
   { contract }: GetDisplayPropsParams<Alp, DefaultDataProps, DefaultContractPositionDefinition>,
  ): Promise<string> {
    return contract.symbol();
 }
    ```

@wpoulin wpoulin closed this Jan 17, 2024
@icyfry icyfry deleted the apollox branch January 22, 2025 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants