Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use target typed new when type is evident #384

Merged
merged 2 commits into from
Feb 10, 2025
Merged

use target typed new when type is evident #384

merged 2 commits into from
Feb 10, 2025

Conversation

SimonCropp
Copy link
Contributor

No description provided.

jodydonetti
jodydonetti approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@jodydonetti jodydonetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm not a huge fan of target typed new, but since you're not the first one point this out and it's definitely not a hill I'd die on, oh well there we go, LGTM.

Thanks.

@jodydonetti jodydonetti merged commit fe5492f into ZiggyCreatures:main Feb 10, 2025
1 check failed
@SimonCropp
Copy link
Contributor Author

yeah. i understand the reasoning. i do think the “where type is evident” cases it does clean up the code

@SimonCropp SimonCropp deleted the use-target-typed-new-when-type-is-evident branch February 10, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodydonetti jodydonetti jodydonetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @jodydonetti