Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant SourceLink #396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove redundant SourceLink #396

wants to merge 2 commits into from
+0 −7

Conversation

SimonCropp
Copy link
Contributor

the sdk does this OOTB now with no need for a nuget ref

@jodydonetti
Copy link
Collaborator

Ah, good catch, I somehow missed it!
Just to be sure, we are talking about this change right?

If your project uses .NET SDK 8+ and is hosted by the above providers it does not need to reference any Source Link packages or set any build properties to include source control information in the PDB.

@SimonCropp
Copy link
Contributor Author

@jodydonetti yep. and many missed it. IMO they should deprecate the package

Labib12
Labib12 previously approved these changes Feb 14, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Labib12 Labib12 Labib12 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @jodydonetti @Labib12