This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Draft
Conversation
github-actions
bot
changed the title
lucac-zilliqa
commented
Aug 22, 2023
| } | ||
|
|
||
| void AccountStore::PrintAddressCache(){ | ||
| for (const std::array<unsigned char, 40>& entry : m_cache) { |
Contributor
There was a problem hiding this comment.
PrintAddressCache should probably lock the mutex as it may be possible for another thread to change the cache and invalidate the iterator, if there is only one thread then it possibly does not need a mutex.
Steve-White-UK
suggested changes
Aug 22, 2023
Contributor
Steve-White-UK
left a comment
Steve-White-UK
left a comment
There was a problem hiding this comment.
If you can add a test to the EvmAcceptanceTests we can take it on board and this test will be executed via ci.
Need to make sure it only looks for short durations and that it doesn't use excessive memory, apart from that it should be OK.
If you provide a test we will test it out as part of our current schedule.
lucac-zilliqa
force-pushed
the
ZIL-5332-debug_accountRange
branch
from
9392d3d to
c51f10c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will add the functionality of debug_accountRange which will return a pagination style response of addresses in the network.
The idea is to implement a cache (an array) which will contain address hexes (still to be determined) which can then be indexed into a slice of the array returned (or also include the corresponding account information).
Potential Discussions:
debug_accountRangecall?