Skip to content
This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ The current live version on the Developer Testnet is Zilliqa [v9.2.5](https://gi

## Zilliqa Improvement Proposal (ZIP)

The Zilliqa Improvement Proposals (ZIPs) are the core protocol standards for the Zilliqa platform.To view or contribute to ZIP, please visit https://github.com/Zilliqa/zip
The Zilliqa Improvement Proposals (ZIPs) are the core protocol standards for the Zilliqa platform. To view or contribute to ZIP, please visit https://github.com/Zilliqa/zip

## Available Features

Expand Down
14 changes: 7 additions & 7 deletions docs/metrics
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Metrics are enabled in the cpp code by including the file

The library support for metrics is provided in libUtils so you must link with this libs if you use metrics in your library module.

Metrics.h contains a number of useful Macros that simplfy the definition of metrics.
Metrics.h contains a number of useful Macros that simplify the definition of metrics.

INCREMENT_METHOD_CALLS_COUNTER(COUNTER, FILTER_CLASS)
INCREMENT_CALLS_COUNTER(COUNTER, FILTER_CLASS, ATTRIBUTE, VALUE)
Expand Down Expand Up @@ -46,19 +46,19 @@ This file contains the filter definition which again is a macro.

One may simply add a new definition into this macro and that's it all complexity taken care of.

This same pattern is used in the trace Filters and is implemented as a 64bit mask where each bit represents one of the classes defined here, this makes filtering extremely fast as its a simple test of the bit been set to enable or disable that class of filter at runtime.
This same pattern is used in the trace Filters and is implemented as a 64bit mask where each bit represents one of the classes defined here, this makes filtering extremely fast as it's a simple test of the bit been set to enable or disable that class of filter at runtime.


That set of instructions covers simple incrementing counters.

You can also have non incrementing metrics, set the metric to any numeric value you please such as height or queue length. These metrics are implemented via a call back which is when the metric is captured.
You can also have non incrementing metrics, set the metric to any numeric value you please such as height or queue length. These metrics are implemented via a call back which is when the metric is captured.


These are slightly more complex in that you define the metric as an observable counter in you class or namespace.
These are slightly more complex in that you define the metric as an observable counter in your class or namespace.

The observable.

In this example it was define in ScillaIPCServer.h
In this example it was defined in ScillaIPCServer.h

zil::metrics::Observable m_bcInfoCount{
Metrics::GetInstance().CreateInt64Gauge(
Expand All @@ -79,5 +79,5 @@ Periodically the open-telemetry services will invoke this method and move the va

All the rest of the naming for the metric by the time it arrives at prometheus is handled by the implementation.

the metric will contains host/pod class type units and any further qualifying attributes and values these will be documented very soon
once the software is delivered.
the metric will contain host/pod class type units and any further qualifying attributes and values these will be documented very soon
once the software is delivered.
2 changes: 1 addition & 1 deletion docs/persistence.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ These key value stores encode [Patricia Merkle Tries](https://ethereum.org/en/de
| `contractStateIndex` | `h160` | [`ProtoStateIndex`] | Deprecated? |
| `contractTrie` | `h256` | `[u8]` | See [tries](#tries) |
| `dsBlocks` | `u64` | [`ProtoDsBlock`] | Maps DS block numbers to DS blocks. |
| `dsCommittee` | `u64` | `string; [PubKey; Peer]` | The value at key `0` will be a `u16` decimal string specifying the leader's ID. All remaining entries will have consequtive keys from `1` to `n`. There is an entry for each member of the DS commitee. Values are a concatenation of a [`Pubkey`] and a [`Peer`].
| `dsCommittee` | `u64` | `string; [PubKey; Peer]` | The value at key `0` will be a `u16` decimal string specifying the leader's ID. All remaining entries will have consecutive keys from `1` to `n`. There is an entry for each member of the DS commitee. Values are a concatenation of a [`Pubkey`] and a [`Peer`].
| `extSeedPubKeys` | `u32` | [`PubKey`] |
| `fallbackBlocks` | | | Deprecated? |
| `metadata` | [`MetaType`] | Depends on the type | `MetaType::LATESTACTIVEDSBLOCKNUM` maps to a `u64`, the rest look to be deprecated.
Expand Down
2 changes: 1 addition & 1 deletion src/libServer/EthRpcMethods.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ std::string EthRpcMethods::GetEthCoinbase() {

throw JsonRpcException(ServerBase::RPC_INVALID_REQUEST,
"Unsupported method: eth_coinbase. Zilliqa mining "
"model is different from that of Etherium");
"model is different from that of Ethereum");
}

Json::Value EthRpcMethods::GetNetListening() {
Expand Down