[master] Experimental - Remove malloc trim call that reclaims STL memory back to OS

src/libData/AccountData/Account.cpp

@@ -401,8 +401,6 @@ bool Account::FetchStateJson(Json::Value& root, const string& vname,
     if (ENABLE_MEMORY_STATS) {
       startMem = DisplayPhysicalMemoryStats("After FetchStateJson", startMem);
     }
-    // Clear STL memory cache
-    DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
   }
 
   if ((vname.empty() && indices.empty()) || vname == "_balance") {

src/libDirectoryService/FinalBlockPostProcessing.cpp

@@ -276,9 +276,6 @@ void DirectoryService::ProcessFinalBlockConsensusWhenDone() {
     }
   }
 
-  // Clear STL memory cache
-  DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
-
   m_mediator.UpdateDSBlockRand();
   m_mediator.UpdateTxBlockRand();
 

src/libLookup/Lookup.cpp

@@ -3620,9 +3620,6 @@ bool Lookup::ProcessSetStateDeltasFromSeed(
                     "AccountStore::GetInstance().DeserializeDelta failed");
         return false;
       }
-      if (txBlkNum % RELEASE_CACHE_INTERVAL == 0) {
-        DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
-      }
       if (!BlockStorage::GetBlockStorage().PutStateDelta(txBlkNum, delta)) {
         LOG_GENERAL(WARNING, "BlockStorage::PutStateDelta failed");
         return false;

src/libNode/FinalBlockProcessing.cpp

@@ -1244,9 +1244,6 @@ bool Node::ProcessFinalBlockCore(uint64_t& dsBlockNumber,
                          << "][" << txBlock.GetHeader().GetBlockNum()
                          << "] LAST");
   }
-  // Clear STL memory cache
-  DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
-
   // Assumption: New PoW done after every block committed
   // If I am not a DS committee member (and since I got this FinalBlock message,
   // then I know I'm not), I can start doing PoW again

src/libPersistence/Retriever.cpp

@@ -168,10 +168,6 @@ bool Retriever::ConstructFromStateDeltas(const uint64_t& lastBlockNum,
                 return false;
               }
 
-              if (j % RELEASE_CACHE_INTERVAL == 0 || j == i) {
-                DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
-              }
-
               TxBlockSharedPtr txBlockPerDelta;
               if (!BlockStorage::GetBlockStorage().GetTxBlock(
                       j, txBlockPerDelta)) {
@@ -238,9 +234,6 @@ bool Retriever::ConstructFromStateDeltas(const uint64_t& lastBlockNum,
                     "AccountStore::GetInstance().DeserializeDelta failed");
         return false;
       }
-      if (extra_delta_index % RELEASE_CACHE_INTERVAL == 0) {
-        DetachedFunction(1, CommonUtils::ReleaseSTLMemoryCache);
-      }
       BlockStorage::GetBlockStorage().PutStateDelta(extra_delta_index++,
                                                     stateDelta);
     }

src/libUtils/CommonUtils.cpp

@@ -27,20 +27,6 @@
 
 using namespace std;
 
-void CommonUtils::ReleaseSTLMemoryCache() {
-#ifdef __linux__
-  LOG_MARKER();
-
-  static mutex relMemoryCacheMutex;
-  if (relMemoryCacheMutex.try_lock()) {
-    malloc_trim(0);
-    relMemoryCacheMutex.unlock();
-  } else {
-    LOG_GENERAL(WARNING, "MemoryCache cleanup already in progress!");
-  }
-#endif
-}
-
 bool CommonUtils::IsVacuousEpoch(const uint64_t& epochNum) {
   return ((epochNum + NUM_VACUOUS_EPOCHS) % NUM_FINAL_BLOCK_PER_POW) == 0;
 }

src/libUtils/CommonUtils.h

@@ -21,8 +21,6 @@
 #include "common/BaseType.h"
 
 namespace CommonUtils {
-void ReleaseSTLMemoryCache();
-
 bool IsVacuousEpoch(const uint64_t& epochNum);
 }  // namespace CommonUtils