[UN-2894] Fix n8n cloud review issues #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepak-Kesavan
force-pushed
the
UN-2894-n-8-n-review-changes
branch
2 times, most recently
from
aacea7b to
3b302ef
Compare
- Remove dependency overrides from package.json - Remove prepublishOnly script, add validate script instead - Add pairedItem linkage to all returnData.push() calls - Replace helpers.request() with helpers.httpRequestWithAuthentication() - Update LLMWhispererApi credentials to use unstract-key header - Add build:dev script for fast development builds - Update workflows to use validate script for comprehensive checks - Update package-lock.json All blocking issues from n8n cloud review have been addressed.
Deepak-Kesavan
force-pushed
the
UN-2894-n-8-n-review-changes
branch
from
3b302ef to
a0f74b1
Compare
- Add dedicated 'audit' script for security checks with high severity threshold - Remove audit from 'validate' script to allow independent execution - Update package-lock.json to reflect current dependency tree
- Add npm audit step after validation - Set continue-on-error to true for visibility without blocking PRs - Audit failures will be visible in CI but won't fail the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed all blocking issues identified during n8n cloud review process.
Changes Made
High Priority (Blocking) Fixes
returnData.push()calls across all nodeshelpers.httpRequestWithAuthentication()in all nodesAdditional Improvements
unstract-keyheader formatbuild:devscript for faster development builds (no lint/audit)Files Changed
package.json- Removed overrides, updated build script.github/workflows/publish.yml- Simplified build stepscredentials/LLMWhispererApi.credentials.ts- Fixed authentication headernodes/LlmWhisperer/LlmWhisperer.node.ts- Added pairedItem, updated authnodes/Unstract/Unstract.node.ts- Added pairedItem, updated authnodes/UnstractHitlFetch/UnstractHitlFetch.node.ts- Added pairedItem, updated authnodes/UnstractHitlPush/UnstractHitlPush.node.ts- Added pairedItem, updated authMedium Priority (Recommended - Not Implemented)
[MEDIUM] External test endpoint for credentials - Not implemented due to:
Testing
Related Issue
Closes UN-2894