fix: disable type.context automatically free

Ziqi-Yang · Sep 6, 2024 · a9a6fb7 · a9a6fb7
1 parent 0b6219d
commit a9a6fb7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/example/el_psy_congaroo.py b/example/el_psy_congaroo.py
@@ -26,6 +26,6 @@
 
 m = utils.parse_assembly(asm_str)
 
-print(m.context) # FIXME
+print(m.context)
 # with core.Context.get_global_context() as ctx:
 #     print(ctx)
diff --git a/src/llvm/Core/type.cpp b/src/llvm/Core/type.cpp
@@ -57,7 +57,9 @@ void bindTypeClasses(nb::module_ &m) {
                    "Whether the type has a known size.\n\n"
                    "Things that don't have a size are abstract types, labels, and void.a")
       .def_prop_ro("context",
-                   [](PymType &t) { return PymContext(LLVMGetTypeContext(t.get())); },
+                   [](PymType &t) {
+                     return PymContext(LLVMGetTypeContext(t.get()), true);
+                   },
                    "Obtain the context to which this type instance is associated.")
       .def_prop_ro("sub_type_number",
                    [](PymType &t) {

diff --git a/src/llvm/types_priv/PymContext.h b/src/llvm/types_priv/PymContext.h
@@ -11,6 +11,10 @@
 class PymContext : public PymLLVMObject<PymContext, LLVMContextRef> {
 public:
   explicit PymContext();
+  /*
+    is_global_context: whether this context is a global context; Or true if you
+    don't want automatically delete the context.
+  */
   explicit PymContext(LLVMContextRef context, bool is_global_context);
   explicit PymContext(LLVMContextRef context);
   static PymContext getGlobalContext();